Skip to content

Conversation

@lxavier
Copy link
Contributor

@lxavier lxavier commented Nov 29, 2018

We probably should add this to all the OpenACC tests, they have no purpose on CPU and we want to make sure there is no mistake in the flags/compiler

We probably should add this to all the OpenACC test, they have no purpose on CPU and we want to make sure there is no mistake in the flags/compiler
@jenkins-cscs
Copy link
Collaborator

Can I test this patch?

@vkarak vkarak requested review from ajocksch and vkarak November 29, 2018 22:23
@vkarak vkarak added this to the ReFrame sprint 2018w48 milestone Nov 29, 2018
@vkarak vkarak changed the title Fail if test is not compiled with OpenACC [WIP] [test] Fail if test is not compiled with OpenACC Dec 3, 2018
@codecov-io
Copy link

codecov-io commented Dec 3, 2018

Codecov Report

Merging #615 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #615   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files          72       72           
  Lines        9005     9005           
=======================================
  Hits         8243     8243           
  Misses        762      762

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16563ff...26f26ec. Read the comment docs.

@lxavier
Copy link
Contributor Author

lxavier commented Dec 3, 2018

could we rename the test automatic_arrays.F90 to automatic_arrays_OpenACC.F90 ?

@vkarak vkarak changed the title [WIP] [test] Fail if test is not compiled with OpenACC [test] Fail if test is not compiled with OpenACC Dec 13, 2018
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak
Copy link
Contributor

vkarak commented Dec 13, 2018

@jenkins-cscs retry dom kesch

@vkarak vkarak merged commit 1ea6fd5 into reframe-hpc:master Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants