Skip to content

Conversation

@victorusu
Copy link
Contributor

The stencil 4 check is a single-local test
The stencil 8 check is a multi-local test

The stencil 4 check is a single-local test
The stencil 8 check is a multi-local test
@pep8speaks
Copy link

pep8speaks commented Jan 8, 2019

Hello @victorusu, Thank you for updating!

Line 167:80: E501 line too long (81 > 79 characters)
Line 169:80: E501 line too long (80 > 79 characters)
Line 171:80: E501 line too long (80 > 79 characters)

Do see the ReFrame Coding Style Guide

Comment last updated on January 17, 2019 at 15:06 Hours UTC

@codecov-io
Copy link

codecov-io commented Jan 8, 2019

Codecov Report

Merging #617 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #617   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files          72       72           
  Lines        9191     9191           
=======================================
  Hits         8421     8421           
  Misses        770      770

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7896a1e...bc9ec21. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these two tests can be combined in a single parameterized test.

@vkarak vkarak added this to the ReFrame sprint 2019w03 milestone Jan 11, 2019
@victorusu
Copy link
Contributor Author

@vkarak, we can combine both tests, but the combination is a bit ugly since both tests have different regexes for the sanity and performance. If you want I can make a base class that encompasses what is common between both tests and have different specialisations for both tests. What do you think?

@vkarak
Copy link
Contributor

vkarak commented Jan 15, 2019

@victorusu I've now seen more carefully the test. You are right. They do seem quite similar, but in fact differ in several minor aspects. So leave them as is. Just fix the redundant imports and we can merge it.

@vkarak
Copy link
Contributor

vkarak commented Jan 17, 2019

@teojgo Can you approve as well?

@vkarak
Copy link
Contributor

vkarak commented Jan 17, 2019

@jenkins-cscs retry none

@vkarak
Copy link
Contributor

vkarak commented Jan 17, 2019

@jenkins-cscs retry none

@vkarak vkarak merged commit ab6a8bc into reframe-hpc:master Jan 18, 2019
@victorusu victorusu deleted the test/hpx-stencil branch October 6, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants