-
Notifications
You must be signed in to change notification settings - Fork 117
[test] Add HPX 1d stencil tests #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The stencil 4 check is a single-local test The stencil 8 check is a multi-local test
|
Hello @victorusu, Thank you for updating!
Do see the ReFrame Coding Style Guide Comment last updated on January 17, 2019 at 15:06 Hours UTC |
Codecov Report
@@ Coverage Diff @@
## master #617 +/- ##
=======================================
Coverage 91.62% 91.62%
=======================================
Files 72 72
Lines 9191 9191
=======================================
Hits 8421 8421
Misses 770 770Continue to review full report at Codecov.
|
a3f3c61 to
bc9ec21
Compare
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these two tests can be combined in a single parameterized test.
|
@vkarak, we can combine both tests, but the combination is a bit ugly since both tests have different regexes for the sanity and performance. If you want I can make a base class that encompasses what is common between both tests and have different specialisations for both tests. What do you think? |
|
@victorusu I've now seen more carefully the test. You are right. They do seem quite similar, but in fact differ in several minor aspects. So leave them as is. Just fix the redundant imports and we can merge it. |
|
@teojgo Can you approve as well? |
|
@jenkins-cscs retry none |
|
@jenkins-cscs retry none |
The stencil 4 check is a single-local test
The stencil 8 check is a multi-local test