-
Notifications
You must be signed in to change notification settings - Fork 117
[test] Add tests for SPEC-ACCEL benchmarks #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sebkelle1 Regarding your comment about the build system, we had issue #301 for creating a generic one, but we decided to close it, because you could essentially achieve any type of custom builds through the current basic build systems. So your use of the |
|
Hello @sebkelle1, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated on January 15, 2019 at 17:30 Hours UTC |
Codecov Report
@@ Coverage Diff @@
## master #618 +/- ##
=======================================
Coverage 91.68% 91.68%
=======================================
Files 74 74
Lines 9256 9256
=======================================
Hits 8486 8486
Misses 770 770Continue to review full report at Codecov.
|
|
@teojgo Can you approve this PR? |
teojgo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the small empty line thing.
|
@jenkins-cscs retry none |
Please don't fry me for my creative use of the
singlesourcebuild_system. I need a separate buildstep to run the provided install script, otherwise I don't have enough time for the benchmarks.
But the spec scripts don't expose any of the compilation for the
build_systemto take care of, soI gave it something useless to do.
Feature request for a
build_systemwith user defined build_cmd?