Skip to content

Conversation

@sekelle
Copy link
Contributor

@sekelle sekelle commented Nov 30, 2018

Please don't fry me for my creative use of the singlesource build_system. I need a separate build
step to run the provided install script, otherwise I don't have enough time for the benchmarks.
But the spec scripts don't expose any of the compilation for the build_system to take care of, so
I gave it something useless to do.
Feature request for a build_system with user defined build_cmd?

@sekelle sekelle changed the title Checks/spec accel Add tests for SPEC-ACCEL benchmarks Nov 30, 2018
@vkarak vkarak changed the title Add tests for SPEC-ACCEL benchmarks [test] Add tests for SPEC-ACCEL benchmarks Dec 1, 2018
@vkarak vkarak requested a review from victorusu December 1, 2018 20:00
@vkarak vkarak requested a review from ajocksch December 1, 2018 20:01
@vkarak
Copy link
Contributor

vkarak commented Dec 1, 2018

@sebkelle1 Regarding your comment about the build system, we had issue #301 for creating a generic one, but we decided to close it, because you could essentially achieve any type of custom builds through the current basic build systems. So your use of the SingleSource build system with prebuild commands is not strange, especially when you have to deal with strange setups.

@vkarak vkarak self-requested a review December 1, 2018 20:06
@teojgo teojgo self-requested a review December 12, 2018 10:12
@pep8speaks
Copy link

pep8speaks commented Jan 9, 2019

Hello @sebkelle1, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated on January 15, 2019 at 17:30 Hours UTC

@codecov-io
Copy link

codecov-io commented Jan 14, 2019

Codecov Report

Merging #618 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #618   +/-   ##
=======================================
  Coverage   91.68%   91.68%           
=======================================
  Files          74       74           
  Lines        9256     9256           
=======================================
  Hits         8486     8486           
  Misses        770      770

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd2fdaf...0b4b60e. Read the comment docs.

@vkarak vkarak added this to the ReFrame sprint 2019w03 milestone Jan 15, 2019
@vkarak
Copy link
Contributor

vkarak commented Jan 15, 2019

@teojgo Can you approve this PR?

Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the small empty line thing.

@vkarak
Copy link
Contributor

vkarak commented Jan 15, 2019

@jenkins-cscs retry none

@vkarak vkarak merged commit e0c4401 into reframe-hpc:master Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants