Skip to content

Conversation

@jgphpc
Copy link
Contributor

@jgphpc jgphpc commented Dec 2, 2018

No description provided.

Signed-off-by: jgp <jgp@cscs.ch>
@jgphpc jgphpc self-assigned this Dec 2, 2018
@teojgo teojgo self-requested a review December 3, 2018 12:39
Signed-off-by: jgp <jgp@cscs.ch>
Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now

@teojgo
Copy link
Contributor

teojgo commented Dec 11, 2018

@jenkins-cscs retry all

@jgphpc
Copy link
Contributor Author

jgphpc commented Dec 12, 2018

@jenkins-cscs retry all

@jgphpc
Copy link
Contributor Author

jgphpc commented Dec 13, 2018

slurm_load_jobs error: Socket timed out on send/recv operation
@jenkins-cscs retry all

@jgphpc
Copy link
Contributor Author

jgphpc commented Dec 14, 2018

@jenkins-cscs retry dom

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall is in a good shape. My comments are only minor.

@pep8speaks
Copy link

pep8speaks commented Jan 15, 2019

Hello @jgphpc, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated on January 18, 2019 at 23:17 Hours UTC

@vkarak vkarak added this to the ReFrame sprint 2019w03 milestone Jan 18, 2019
@codecov-io
Copy link

codecov-io commented Jan 18, 2019

Codecov Report

Merging #620 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #620   +/-   ##
=======================================
  Coverage   91.68%   91.68%           
=======================================
  Files          74       74           
  Lines        9256     9256           
=======================================
  Hits         8486     8486           
  Misses        770      770

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d8b785...d5e7916. Read the comment docs.

@vkarak vkarak changed the title [test] Add new mpi_init_thread check [test] Add new MPI_Init_thread() check Jan 18, 2019
@vkarak vkarak merged commit e5ef7fd into reframe-hpc:master Jan 19, 2019
@jgphpc jgphpc deleted the mpi_init_thread branch March 23, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants