[bugfix] Do not crash if Slurm node does not contain partition information #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The `SlurmNode` attibutes: partitions, active_features and `state` can now be `None`. * Throw a `JobError` when the `nodename` cannot be extracted. * Adjust the unit tests to reflect the above changes.
vkarak
approved these changes
Dec 3, 2018
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
lgtm, except for a couple of minor comments.
vkarak
changed the title
None
vkarak
changed the title
None
vkarak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SlurmNodeattibutes: partitions, active_features andstatecannow be
None.Throw a
JobErrorwhen thenodenamecannot be extracted.Adjust the unit tests to reflect the above changes.
Fixes #605