[test] Add Likwid benchmarks for cache, memory and cross-socket bandwidths #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @sebkelle1, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated on January 28, 2019 at 13:37 Hours UTC |
jgphpc
reviewed
Jan 15, 2019
jgphpc
reviewed
Jan 15, 2019
teojgo
requested changes
Jan 18, 2019
vkarak
requested changes
Jan 18, 2019
vkarak
changed the title
vkarak
approved these changes
Jan 22, 2019
Contributor
|
@teojgo Can you approve this PR? Looks good now. |
teojgo
requested changes
Jan 23, 2019
Contributor
teojgo
left a comment
teojgo
left a comment
There was a problem hiding this comment.
Please make sure to fix the coding style issues reported by pep8speaks.
Contributor
|
@sebkelle1 Can you fix the coding style issues so that we can merge it? |
Codecov Report
@@ Coverage Diff @@
## master #647 +/- ##
=======================================
Coverage 91.82% 91.82%
=======================================
Files 77 77
Lines 9366 9366
=======================================
Hits 8600 8600
Misses 766 766Continue to review full report at Codecov.
|
vkarak
force-pushed
the
checks/cpu-bandwidth
branch
from
bec5b29 to
a57a880
Compare
teojgo
approved these changes
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please indicate what group/user to use in line 62.
e.g.
getpwd.getuser()