Skip to content

[feat] Add support for setting a minimum number of required tasks in tests with flexible task allocation #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 26, 2019
Merged

[feat] Add support for setting a minimum number of required tasks in tests with flexible task allocation #652

merged 5 commits into from
Jan 26, 2019

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Jan 18, 2019

Fixes #640

@teojgo teojgo self-assigned this Jan 18, 2019
@teojgo teojgo requested review from victorusu and vkarak January 18, 2019 09:34
@teojgo teojgo changed the title [feature] Support setting a min number of flex_alloc_tasks [feat] Support setting a min number of flex_alloc_tasks Jan 18, 2019
@codecov-io
Copy link

codecov-io commented Jan 18, 2019 •
edited
Loading

Codecov Report

Merging #652 into master will increase coverage by 0.01%.
The diff coverage is 96.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
+ Coverage    91.8%   91.82%   +0.01%     
==========================================
  Files          77       77              
  Lines        9346     9366      +20     
==========================================
+ Hits         8580     8600      +20     
  Misses        766      766
Impacted Files Coverage Δ
reframe/core/pipeline.py 91.72% <ø> (ø) ⬆️
unittests/test_schedulers.py 98.24% <100%> (+0.07%) ⬆️
reframe/core/schedulers/__init__.py 94.07% <90.9%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02e0d16...69a84d7. Read the comment docs.

@vkarak vkarak added this to the ReFrame sprint 2019w03 milestone Jan 18, 2019
@vkarak vkarak changed the title [feat] Support setting a min number of flex_alloc_tasks [feat] Add support for setting a minimum number of required tasks in tests with flexible task allocation Jan 21, 2019
vkarak
vkarak requested changes Jan 21, 2019
View reviewed changes
victorusu
victorusu approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

vkarak
vkarak requested changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. Looks good except from a couple of minor improvements.

@vkarak vkarak merged commit 17a9044 into reframe-hpc:master Jan 26, 2019
@teojgo teojgo deleted the feature/min_flex_nodes branch February 1, 2019 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@victorusu victorusu victorusu approved these changes

Assignees

@teojgo teojgo

Labels

enhancement prio: normal

Projects

None yet

Milestone

ReFrame sprint 2019w03

Development

Successfully merging this pull request may close these issues.

4 participants

@teojgo @codecov-io @vkarak @victorusu