[test] Porting tests to new syntax #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a first set of remaining tests being ported to the new syntax.
|
Hello @kraushm, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated on January 28, 2019 at 17:00 Hours UTC |
vkarak
changed the title
vkarak
requested changes
Jan 22, 2019
teojgo
requested changes
Jan 25, 2019
Contributor
teojgo
left a comment
teojgo
left a comment
There was a problem hiding this comment.
Also take into account the pep8speak comments.
teojgo
requested changes
Jan 25, 2019
Contributor
teojgo
left a comment
teojgo
left a comment
There was a problem hiding this comment.
lgtm now, just fix the pep8 issues.
teojgo
approved these changes
Jan 25, 2019
Contributor
Author
|
@jenkins-cscs retry kesch |
Contributor
|
@jenkins-cscs retry all |
Contributor
|
@victorusu @teojgo With this PR the name of some tests. This will affect your scripts. Are you ok with that? |
vkarak
approved these changes
Jan 28, 2019
Contributor
|
@vkarak I can easily adapt to take into account the name change. |
Contributor
Contributor
|
@jenkins-cscs retry none |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first set of remaining tests being ported to the new syntax.
Fixes #592.