[test] Add CPU affinity test #657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
For the sake of clarity, i would add (the output of daint-gpudaint-mc |
teojgo
approved these changes
Jan 25, 2019
Contributor
teojgo
left a comment
teojgo
left a comment
There was a problem hiding this comment.
lgtm, I also tried myself and it works fine.
Contributor
|
For info, there are variations between compilers on daint-mc (-n1 -c36, no multithreading): |
Contributor
|
@jenkins-cscs retry daint |
vkarak
requested changes
Jan 28, 2019
victorusu
previously requested changes
Jan 28, 2019
Contributor
|
@jgphpc You have a point with your comment. However, I wouldn't block this PR for this. I would rather create a follow up one for fixing what you suggest. |
Contributor
|
that was my goal: we need to open a new issue after this one.
|
Codecov Report
@@ Coverage Diff @@
## master #657 +/- ##
=======================================
Coverage 91.84% 91.84%
=======================================
Files 77 77
Lines 9403 9403
=======================================
Hits 8636 8636
Misses 767 767Continue to review full report at Codecov.
|
Contributor
|
@victorusu Can you check and approve this PR? |
vkarak
dismissed
victorusu’s stale review
All comments are addressed; we need to merge this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #100