Skip to content

Conversation

@lucamar
Copy link
Contributor

@lucamar lucamar commented Jan 28, 2019

I have added the build and run of DGEMM using PrgEnv-intel with MKL.
The performance values are still the same, I have tested Dom for the time being and the performance fits the current range.
I have inserted a new tag benchmark, therefore the performance thresholds might change with respect to diagnostic.

@pep8speaks
Copy link

pep8speaks commented Jan 28, 2019

Hello @lucamar, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated on February 08, 2019 at 15:38 Hours UTC

@lucamar
Copy link
Contributor Author

lucamar commented Jan 28, 2019

Note that you need to run reframe -P normal on Dom to get the node assignment correctly.

@codecov-io
Copy link

codecov-io commented Jan 28, 2019

Codecov Report

Merging #662 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #662   +/-   ##
=======================================
  Coverage   91.84%   91.84%           
=======================================
  Files          77       77           
  Lines        9366     9366           
=======================================
  Hits         8602     8602           
  Misses        764      764

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 383e672...04562f2. Read the comment docs.

@vkarak vkarak changed the title DGEMM using mkl [test] Add DGEMM test using MKL Jan 28, 2019
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have a couple of comments. But overall lgtm

Removed lines as suggested
Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak changed the title [test] Add DGEMM test using MKL [test] Extend DGEMM test for using MKL Feb 7, 2019
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a minor comment. Other than that it lgtm.

@vkarak vkarak modified the milestone: Upcoming sprint Feb 7, 2019
@vkarak
Copy link
Contributor

vkarak commented Feb 8, 2019

@victorusu Can you recheck and approve?

@vkarak
Copy link
Contributor

vkarak commented Feb 8, 2019

I will move the test to microbenchmarks

@victorusu
Copy link
Contributor

I will merge, as soon as the tests pass.

@vkarak vkarak merged commit fa752d4 into reframe-hpc:master Feb 8, 2019
@lucamar lucamar deleted the dgemm-mkl branch February 25, 2019 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants