-
Notifications
You must be signed in to change notification settings - Fork 117
[test] Extend DGEMM test for using MKL #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @lucamar, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated on February 08, 2019 at 15:38 Hours UTC |
|
Note that you need to run |
Codecov Report
@@ Coverage Diff @@
## master #662 +/- ##
=======================================
Coverage 91.84% 91.84%
=======================================
Files 77 77
Lines 9366 9366
=======================================
Hits 8602 8602
Misses 764 764Continue to review full report at Codecov.
|
victorusu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have a couple of comments. But overall lgtm
Removed lines as suggested
teojgo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a minor comment. Other than that it lgtm.
|
@victorusu Can you recheck and approve? |
|
I will move the test to microbenchmarks |
|
I will merge, as soon as the tests pass. |
I have added the build and run of
DGEMMusingPrgEnv-intelwithMKL.The performance values are still the same, I have tested
Domfor the time being and the performance fits the current range.I have inserted a new tag
benchmark, therefore the performance thresholds might change with respect todiagnostic.