[feat] Add logging handler for sending records to syslog

[ZQyou]

• Support syslog handler in Logging and Performance Logging

Closes #671
Closes #699

[pep8speaks]

Hello @ZQyou, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated on March 01, 2019 at 12:08 Hours UTC

[jenkins-cscs]

Can I test this patch?

[vkarak]

@jenkins-cscs retry all

[codecov-io]

Codecov Report

Merging #675 into master will decrease coverage by 0.05%.
The diff coverage is 79.06%.

@@            Coverage Diff             @@
##           master     #675      +/-   ##
==========================================
- Coverage   91.89%   91.83%   -0.06%     
==========================================
  Files          77       77              
  Lines        9452     9494      +42     
==========================================
+ Hits         8686     8719      +33     
- Misses        766      775       +9

Impacted Files	Coverage Δ
reframe/core/logging.py	83.54% <75%> (-0.69%)	⬇️
unittests/test_logging.py	97.22% <84.21%> (-1.27%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b21792...45f2c53. Read the comment docs.

[vkarak]

@ZQyou Hmm, looks like that sth has gone wrong with your branch. It seems that you have reapplied several commits already in the master. Checking the history of your branches, it seems that you have rebased over the main master and then merged again with your local master before applying your new commit. I'll see how I can fix that.

[ZQyou]

@vkarak Apology for any inconvenience caused. Here is what I did: merge upstream master into my local master and then rebase local branch. Somehow it was asked to pull my remote branch before I push local branch then I did it.

If the issue is complicated, can I just cancel this request and submit another one?

[vkarak]

Yes, as soon as you rebase a branch that you have already pushed, you need to do a forced update to the remote branch, because you have essentially reapplied all your commits, so the two branches have diverged according to Git. That's why it was asking you for a pull first. You can fix it by cherry-picking your commits in a clean local branch and force pushing to your remote branch.

# in your local copy
git checkout -b clean_branch
git cherry-pick COMMIT1 COMMIT2 ...
git push your_remote +clean_branch:feature/syslog_handler

The + will do the forced update on the remote branch.

[vkarak]

@ZQyou I fixed your PR and I forced updated into your remote branch. Can you check that I haven't missed any of your changes? In order now to update your local branch, you should not just pull, because we will end up in the same situation as before (Git will merge the remote with your local branch). You just need to do a hard reset of your local branch to the status of the remote:

# In your local repo
git checkout feature/syslog_handler
git reset --hard your_remote/feature/syslog_handler

Then you should be able to see only the two useful commits.

[ZQyou]

@vkarak Thank you. There is no change missing. I have tested this branch on our Linux server and run a local unittest to test address='/var/run/syslog' on Mac. Both work fine.

[vkarak]

@ZQyou Thanks for your PR. Looks good. I will merge it as soon as the CI passes.

[vkarak]

@jenkins-cscs retry all

[vkarak]

@ZQyou I've also update the documentation and I have added a unit test that tests the actual logging through syslog. I've done an adaptation for OSX. Now it's ready to be merged.