Skip to content

[test] Add Fulen as a supported system in CSCS config #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 11, 2019
Merged

[test] Add Fulen as a supported system in CSCS config #684

merged 13 commits into from
Mar 11, 2019

Conversation

@rsarm
Copy link
Contributor

@rsarm rsarm commented Feb 19, 2019

Fixes #609

@rsarm rsarm added this to the ReFrame sprint 2019w07 milestone Feb 19, 2019
@rsarm rsarm self-assigned this Feb 19, 2019
@rsarm rsarm requested review from victorusu and vkarak February 19, 2019 10:32
@codecov-io
Copy link

codecov-io commented Feb 19, 2019 •
edited
Loading

Codecov Report

Merging #684 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #684   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files          77       77           
  Lines        9494     9494           
=======================================
  Hits         8721     8721           
  Misses        773      773

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89d5efe...ac02031. Read the comment docs.

victorusu
victorusu approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latm

vkarak
vkarak requested changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the reason to disable Fulen from the CI.

victorusu
victorusu requested changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see a reason to disable Fulen from the CI too!

@sekelle sekelle removed this from the ReFrame sprint 2019w07 milestone Feb 25, 2019
vkarak
vkarak requested changes Feb 26, 2019
View reviewed changes
@vkarak
Copy link
Contributor

vkarak commented Mar 8, 2019

Adding Fulen to CI has no added value. We can achieve the same with VMs on Pollux. We should only keep the configuration entry in ReFrame's entry.

@pep8speaks
Copy link

pep8speaks commented Mar 9, 2019 •
edited
Loading

Hello @rsarm, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2019-03-11 11:00:04 UTC

@vkarak
Copy link
Contributor

vkarak commented Mar 11, 2019

@victorusu Can you approve this PR?

@vkarak vkarak changed the title [test] Add Fulen to config [test] Add Fulen as a supported system in CSCS config Mar 11, 2019
@vkarak vkarak merged commit a08800e into reframe-hpc:master Mar 11, 2019
@rsarm rsarm deleted the config/fulen branch November 26, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teojgo teojgo teojgo left review comments

@vkarak vkarak vkarak approved these changes

@victorusu victorusu victorusu approved these changes

Assignees

@rsarm rsarm

Labels

prio: normal

Projects

None yet

Milestone

ReFrame sprint 2019w10

Development

Successfully merging this pull request may close these issues.

7 participants

@rsarm @codecov-io @vkarak @pep8speaks @victorusu @teojgo @sekelle