Skip to content

[test] Add test for Fieldextra COSMO postprocessing #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 1, 2019
Merged

[test] Add test for Fieldextra COSMO postprocessing #685

merged 6 commits into from
Mar 1, 2019

Conversation

@kraushm
Copy link
Contributor

@kraushm kraushm commented Feb 20, 2019

Fieldextra tests (cookbook + performance test) for Kesch

@kraushm kraushm added this to the ReFrame sprint 2019w07 milestone Feb 20, 2019
@kraushm kraushm self-assigned this Feb 20, 2019
@kraushm kraushm requested review from lucamar and vkarak February 20, 2019 11:10
@pep8speaks
Copy link

pep8speaks commented Feb 20, 2019 •
edited
Loading

Hello @kraushm, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated on March 01, 2019 at 15:57 Hours UTC

@kraushm
Copy link
Contributor Author

kraushm commented Feb 20, 2019

This only covers the first set of tests, i. e. the cookbook to check for sanity.

@kraushm
Copy link
Contributor Author

kraushm commented Feb 21, 2019 •
edited
Loading

Test will not pass in any case, since the module is not yet present in the production stack on the system. Forgot that my test is not tagged production.

@codecov-io
Copy link

codecov-io commented Feb 21, 2019

Codecov Report

Merging #685 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #685   +/-   ##
=======================================
  Coverage   91.81%   91.81%           
=======================================
  Files          77       77           
  Lines        9455     9455           
=======================================
  Hits         8681     8681           
  Misses        774      774

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f701ca5...d3791c6. Read the comment docs.

@kraushm kraushm changed the title WIP: Test for fieldextra Test for fieldextra Feb 22, 2019
@sekelle sekelle removed this from the ReFrame sprint 2019w07 milestone Feb 25, 2019
@kraushm kraushm added this to the ReFrame sprint 2019w07 milestone Feb 25, 2019
@teojgo teojgo changed the title Test for fieldextra [test] Test for fieldextra Feb 26, 2019
@vkarak vkarak changed the title [test] Test for fieldextra [test] Add test for Fieldextra COSMO postprocessing Feb 27, 2019
vkarak
vkarak requested changes Feb 27, 2019
View reviewed changes
@kraushm kraushm requested a review from vkarak February 28, 2019 14:45
vkarak
vkarak requested changes Feb 28, 2019
View reviewed changes
@vkarak vkarak merged commit f5ff16c into reframe-hpc:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@lucamar lucamar Awaiting requested review from lucamar

Assignees

@kraushm kraushm

Labels

prio: normal

Projects

None yet

Milestone

ReFrame sprint 2019w10

Development

Successfully merging this pull request may close these issues.

6 participants

@kraushm @pep8speaks @codecov-io @vkarak @teojgo @sekelle