Skip to content

Conversation

@kraushm
Copy link
Contributor

@kraushm kraushm commented Feb 22, 2019

fixes the Jira issue: https://jira.cscs.ch/browse/UES-219

@kraushm kraushm added this to the ReFrame sprint 2019w07 milestone Feb 22, 2019
@kraushm kraushm self-assigned this Feb 22, 2019
@kraushm kraushm requested review from teojgo and vkarak February 22, 2019 09:31
@kraushm
Copy link
Contributor Author

kraushm commented Feb 22, 2019

I guess it makes sense to then also remove the old folder inside the docs?

@codecov-io
Copy link

codecov-io commented Feb 22, 2019

Codecov Report

Merging #687 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #687      +/-   ##
==========================================
+ Coverage   91.81%   91.83%   +0.02%     
==========================================
  Files          77       77              
  Lines        9455     9455              
==========================================
+ Hits         8681     8683       +2     
+ Misses        774      772       -2
Impacted Files Coverage Δ
reframe/core/config.py 84.48% <0%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f701ca5...720f3be. Read the comment docs.

Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old directory has to be removed indeed. Also delete the link_old_docs.sh script, remove the old folder from the exclude patterns in conf.py and also the old related staff from the Makefile.

@kraushm kraushm requested a review from teojgo February 22, 2019 14:16
Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kraushm kraushm changed the title WIP: removing link to docs vor ver<=2.6.1 removing link to docs vor ver<=2.6.1 Feb 22, 2019
@sekelle sekelle removed this from the ReFrame sprint 2019w07 milestone Feb 25, 2019
@kraushm kraushm added this to the ReFrame sprint 2019w07 milestone Feb 25, 2019
@vkarak vkarak changed the title removing link to docs vor ver<=2.6.1 [doc] Remove link to prior to 2.6.1 documentation Feb 26, 2019
@vkarak vkarak merged commit 06a905e into reframe-hpc:master Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants