[bugfix] Fix bug ignoring a partition defined in 'access' #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `SlurmNode` attributes are set to empty sets if they cannot be retrieved by the corresponding description. * Create abstract method `list_all_nodes` on the base `Job` class. * Remove method `get_partition_nodes`. * Create more unittests for flexible allocation.
Contributor
Author
|
@jenkins-cscs retry daint |
vkarak
requested changes
Feb 27, 2019
vkarak
approved these changes
Feb 28, 2019
Codecov Report
@@ Coverage Diff @@
## master #693 +/- ##
==========================================
+ Coverage 91.89% 91.89% +<.01%
==========================================
Files 77 77
Lines 9446 9452 +6
==========================================
+ Hits 8680 8686 +6
Misses 766 766
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SlurmNodeattributes are set to empty sets if they cannot beretrieved by the corresponding description.
Create abstract method
get_all_nodeson the baseJobclass.Remove method
get_partition_nodes.Create more unittests for flexible allocation.
Fixes #692