[bugfix] Fix error message in case of performance errors #704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create the `PerformanceError` exception class when used the performance of a test is not within the reference values. * Modify the corresponding unittests to except a `PerformanceError`.
vkarak
requested changes
Mar 6, 2019
Contributor
Author
|
@jenkins-cscs retry all |
vkarak
requested changes
Mar 7, 2019
vkarak
changed the title
Contributor
|
@teojgo I am taking over the changes for fixing how the error message prefixes are printed. |
Contributor
Author
|
@vkarak good, I have pushed the reverted unittests so you can continue from there. |
Contributor
|
@teojgo Yep, I've took the changes already. |
vkarak
approved these changes
Mar 14, 2019
Contributor
|
@jenkins-cscs retry daint |
Codecov Report
@@ Coverage Diff @@
## master #704 +/- ##
==========================================
- Coverage 91.83% 91.82% -0.02%
==========================================
Files 77 77
Lines 9494 9488 -6
==========================================
- Hits 8719 8712 -7
- Misses 775 776 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PerformanceErrorexception class when usedthe performance of a test is not within the reference values.
PerformanceError.Closes #677