Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Mar 15, 2019

This PR fixes the behaviour of the -p option when it is used with regular expressions. The -p option has also the effect of restricting the programming environments to run with. Although this still works fine in old-style cases, e.g., -p PrgEnv-gnu, it fails to do so when passing regular expressions, for example, -p PrgEnv-(gnu|pgi). Although this will select all the tests that support either PrgEnv-gnu or PrgEnv-pgi, it will not run them. This PR fixes this.

- Define the set of run environments correctly when `-p` option is used
  with regular expressions
@vkarak
Copy link
Contributor Author

vkarak commented Mar 15, 2019

@jenkins-cscs retry kesch

@codecov-io
Copy link

codecov-io commented Mar 15, 2019

Codecov Report

Merging #716 into master will decrease coverage by <.01%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #716      +/-   ##
==========================================
- Coverage   91.77%   91.77%   -0.01%     
==========================================
  Files          77       77              
  Lines        9501     9504       +3     
==========================================
+ Hits         8720     8722       +2     
- Misses        781      782       +1
Impacted Files Coverage Δ
unittests/test_cli.py 96.1% <0%> (-0.32%) ⬇️
reframe/frontend/cli.py 80.79% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64b8f37...3ed3d71. Read the comment docs.

@vkarak vkarak merged commit 20544c7 into reframe-hpc:master Mar 15, 2019
@vkarak vkarak deleted the bugfix/regex-select-run-prgenv branch March 15, 2019 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants