Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Apr 4, 2019

No description provided.

@teojgo teojgo requested a review from vkarak April 4, 2019 11:44
@teojgo teojgo changed the title [bugfix] Update the test for the new PE [bugfix] Update Nvidia35Resolve test for the new PE Apr 4, 2019
@vkarak vkarak removed the bugfix label Apr 4, 2019
@vkarak vkarak changed the title [bugfix] Update Nvidia35Resolve test for the new PE [test] Update Nvidia35Resolve test for the new PE Apr 4, 2019
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We cannot merge this before the end of this sprint.
  • This is not a bug fix, but an update to a test.

@vkarak vkarak added this to the ReFrame sprint 2019w15 milestone Apr 10, 2019
@codecov-io
Copy link

Codecov Report

Merging #732 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #732      +/-   ##
==========================================
+ Coverage   91.76%   91.79%   +0.02%     
==========================================
  Files          76       76              
  Lines        9501     9501              
==========================================
+ Hits         8719     8721       +2     
+ Misses        782      780       -2
Impacted Files Coverage Δ
reframe/core/config.py 85.84% <0%> (+1.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39f6d66...43a3500. Read the comment docs.

@teojgo teojgo self-assigned this Apr 10, 2019
vkarak added a commit to vkarak/reframe that referenced this pull request Apr 11, 2019
[test] Update Nvidia35Resolve test for the new PE
@vkarak
Copy link
Contributor

vkarak commented Apr 11, 2019

@jenkins-cscs retry dom

1 similar comment
@vkarak
Copy link
Contributor

vkarak commented Apr 11, 2019

@jenkins-cscs retry dom

@vkarak
Copy link
Contributor

vkarak commented Apr 11, 2019

Github is confused. This PR is already merged!

@vkarak vkarak closed this Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants