[feat] Enable environment variable substitution in shell code emitted by build systems #744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that environment variables will be properly expanded if specified.
|
Hello @vkarak, Thank you for submitting the Pull Request!
Do see the ReFrame Coding Style Guide |
Contributor
Author
|
@pep8speaks This is an exception, sorry! |
teojgo
requested changes
Apr 9, 2019
teojgo
approved these changes
Apr 9, 2019
Contributor
Author
|
@jenkins-cscs retry all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was achieved by simply using double quotes instead of single ones in the emitted variables, e.g., `CXXFLAGS="-Wall -std=c++11 $MOREFLAGS". In your test you may write things like the following:
Fixes #702.