Skip to content

[bugfix] Fix failure in Intel Advisor Roofline check #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 10, 2019
Merged

[bugfix] Fix failure in Intel Advisor Roofline check #745

merged 15 commits into from
Apr 10, 2019

Conversation

@jgphpc
Copy link
Contributor

@jgphpc jgphpc commented Apr 9, 2019 •
edited
Loading

@jgphpc jgphpc self-assigned this Apr 9, 2019
@jgphpc jgphpc requested a review from teojgo April 9, 2019 11:55
@vkarak
Copy link
Contributor

vkarak commented Apr 9, 2019

@jgphpc Please have a look at the PR title guide here: https://github.com/eth-cscs/reframe/wiki/contributing-to-reframe#pull-request-policy

@vkarak vkarak added this to the ReFrame sprint 2019w13 milestone Apr 9, 2019
@jgphpc jgphpc changed the title [test] moving roofline test to advisor/2019u3 [bugfix] Fix advisor roofline check failure Apr 9, 2019
@pep8speaks
Copy link

pep8speaks commented Apr 9, 2019 •
edited
Loading

Hello @jgphpc, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2019-04-10 08:39:51 UTC

@jgphpc
Copy link
Contributor Author

jgphpc commented Apr 9, 2019 •
edited
Loading

Status update: check now uses latest advisor's version (2019u3)

  • check fails on dom (slurmstepd: error) -> removing dom from the list
  • check should now pass on daint, if not i will make a bug report.

@codecov-io
Copy link

codecov-io commented Apr 9, 2019

Codecov Report

Merging #745 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
- Coverage   91.79%   91.76%   -0.03%     
==========================================
  Files          76       76              
  Lines        9501     9501              
==========================================
- Hits         8721     8719       -2     
- Misses        780      782       +2
Impacted Files Coverage Δ
reframe/core/config.py 84.07% <0%> (-1.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b77f3e7...5fab1b8. Read the comment docs.

@jgphpc jgphpc requested a review from vkarak April 9, 2019 17:15
@jgphpc
Copy link
Contributor Author

jgphpc commented Apr 9, 2019

not ready to be merged yet

@vkarak vkarak changed the title [bugfix] Fix advisor roofline check failure [bugfix] Fix failure in Intel Advisor Roofline check Apr 9, 2019
@vkarak
Copy link
Contributor

vkarak commented Apr 9, 2019

@jgphpc Shouldn't it be a WIP then?

vkarak
vkarak approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit dcee242 into reframe-hpc:master Apr 10, 2019
@jgphpc jgphpc deleted the UES-335 branch April 10, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@teojgo teojgo Awaiting requested review from teojgo

Assignees

@jgphpc jgphpc

Labels

prio: normal

Projects

None yet

Milestone

ReFrame sprint 2019w13

Development

Successfully merging this pull request may close these issues.

4 participants

@jgphpc @vkarak @pep8speaks @codecov-io