[bugfix] Do not crash when invalid regular expressions are passed to the test selection options #757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Throw a `ReframeError` if an invalid regex is passed to one of the filtering functions. * Add corresponding unittests.
vkarak
requested changes
Apr 15, 2019
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
lgtm. I have just a minor comment.
vkarak
approved these changes
Apr 15, 2019
vkarak
changed the title
Codecov Report
@@ Coverage Diff @@
## master #757 +/- ##
==========================================
+ Coverage 91.51% 91.52% +0.01%
==========================================
Files 76 76
Lines 9532 9548 +16
==========================================
+ Hits 8723 8739 +16
Misses 809 809
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw a
ReframeErrorif an invalid regex is passed to one of thefiltering functions.
Add corresponding unittests.
Fixes #730