Skip to content

Conversation

@ChristopherBignamini
Copy link
Contributor

@ChristopherBignamini ChristopherBignamini commented Apr 15, 2019

Fixes UES-77.

@pep8speaks
Copy link

pep8speaks commented Apr 15, 2019

Hello @ChristopherBignamini, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2019-06-18 08:26:23 UTC

@ChristopherBignamini ChristopherBignamini changed the title WIP [test] Gridtools mini app test [WIP] [test] Gridtools mini app test Apr 15, 2019
@vkarak vkarak requested review from teojgo and victorusu April 16, 2019 14:44
@vkarak vkarak added this to the ReFrame sprint 2019w15 milestone Apr 16, 2019
@codecov-io
Copy link

codecov-io commented May 14, 2019

Codecov Report

Merging #760 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #760   +/-   ##
=======================================
  Coverage   91.87%   91.87%           
=======================================
  Files          80       80           
  Lines       10277    10277           
=======================================
  Hits         9442     9442           
  Misses        835      835

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 971f305...3c6b4c0. Read the comment docs.

@vkarak
Copy link
Contributor

vkarak commented Jun 5, 2019

@ChristopherBignamini Is this still a WIP?

@vkarak vkarak changed the title [WIP] [test] Gridtools mini app test [test] Add GridTools mini app benchmark Jun 5, 2019
@vkarak vkarak removed this from the ReFrame sprint 2019w22 milestone Jun 12, 2019
Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now

@vkarak
Copy link
Contributor

vkarak commented Jun 18, 2019

@jenkins-cscs retry daint

@vkarak
Copy link
Contributor

vkarak commented Jun 18, 2019

@jenkins-cscs retry none

@vkarak vkarak merged commit a55890a into reframe-hpc:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants