[test] Add ert roofline check (gpu) #775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgphpc
commented
May 7, 2019
cscs-checks/tools/profiling_and_debugging/berkeley-ert-nvprof.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
teojgo
requested changes
May 7, 2019
cscs-checks/tools/profiling_and_debugging/berkeley-ert-nvprof.py
Outdated
Show resolved
Hide resolved
|
Hello @jgphpc, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2019-05-09 12:50:54 UTC |
vkarak
requested changes
May 7, 2019
cscs-checks/tools/profiling_and_debugging/berkeley-ert-nvprof.py
Outdated
Show resolved
Hide resolved
cscs-checks/tools/profiling_and_debugging/berkeley-ert-nvprof.py
Outdated
Show resolved
Hide resolved
vkarak
approved these changes
May 8, 2019
Contributor
|
@teojgo Can you approve this PR? |
Contributor
|
@vkarak there is one particular case that fails in the sanity step |
Contributor
|
@vkarak you can merge it now |
teojgo
approved these changes
May 9, 2019
Contributor
|
@jenkins-cscs retry none |
Codecov Report
@@ Coverage Diff @@
## master #775 +/- ##
=======================================
Coverage 91.52% 91.52%
=======================================
Files 76 76
Lines 9548 9548
=======================================
Hits 8739 8739
Misses 809 809Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix UES-213 (gpu)