Skip to content

Conversation

@rsarm
Copy link
Contributor

@rsarm rsarm commented May 17, 2019

@rsarm rsarm added this to the ReFrame sprint 2019w20 milestone May 17, 2019
@rsarm rsarm requested a review from vkarak May 17, 2019 13:26
@rsarm rsarm self-assigned this May 17, 2019
@vkarak vkarak requested a review from teojgo May 17, 2019 13:44
@vkarak vkarak changed the title WIP [feat] Add abstraction class for containers and Docker implementation WIP [feat] Add high-level API for container platforms May 23, 2019
@vkarak
Copy link
Contributor

vkarak commented May 23, 2019

@rsarm Rename also the containerplatform.py to containers.py.

@codecov-io
Copy link

codecov-io commented May 23, 2019

Codecov Report

Merging #787 into master will increase coverage by 0.22%.
The diff coverage is 88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #787      +/-   ##
==========================================
+ Coverage   91.51%   91.74%   +0.22%     
==========================================
  Files          76       80       +4     
  Lines        9550    10454     +904     
==========================================
+ Hits         8740     9591     +851     
- Misses        810      863      +53
Impacted Files Coverage Δ
reframe/core/exceptions.py 81.63% <100%> (-0.4%) ⬇️
reframe/core/containerplatform.py 81.81% <81.81%> (ø)
unittests/test_containerplatform.py 96.66% <96.66%> (ø)
unittests/test_policies.py 98.86% <0%> (-0.32%) ⬇️
unittests/resources/settings.py 100% <0%> (ø) ⬆️
reframe/frontend/dependency.py 93.47% <0%> (ø)
...s/resources/checks_unlisted/dependencies/normal.py 100% <0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 758f93e...b2d9cd6. Read the comment docs.

@vkarak
Copy link
Contributor

vkarak commented May 24, 2019

@rsarm Is this still a WIP?

@rsarm rsarm changed the title WIP [feat] Add high-level API for container platforms [feat] Add high-level API for container platforms May 24, 2019
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment is should we call it container_platform or container_runtime? @teojgo @rsarm What do you think?

@vkarak vkarak merged commit 1a7ff13 into reframe-hpc:master May 27, 2019
@rsarm rsarm deleted the containerplatform branch November 26, 2019 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants