Skip to content

[bugfix] Fix filename order in build error message #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2019
Merged

[bugfix] Fix filename order in build error message #790

merged 2 commits into from
May 19, 2019

Conversation

@aurianer
Copy link
Contributor

@aurianer aurianer commented May 17, 2019

Fix #789

@jenkins-cscs
Copy link
Collaborator

jenkins-cscs commented May 17, 2019

Can I test this patch?

@teojgo teojgo added this to the ReFrame sprint 2019w20 milestone May 17, 2019
@teojgo teojgo requested review from teojgo and vkarak May 17, 2019 15:02
@teojgo
Copy link
Contributor

teojgo commented May 17, 2019

@jenkins-cscs retry all

@teojgo teojgo changed the title Fix filename order in error message [bugfix] Fix filename order in error message May 17, 2019
teojgo
teojgo approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak changed the title [bugfix] Fix filename order in error message [bugfix] Fix filename order in build error message May 17, 2019
@vkarak
Copy link
Contributor

vkarak commented May 19, 2019

@jenkins-cscs retry daint

@vkarak
Copy link
Contributor

vkarak commented May 19, 2019

@jenkins-cscs retry none

@codecov-io
Copy link

codecov-io commented May 19, 2019

Codecov Report

Merging #790 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #790   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files          76       76           
  Lines        9550     9550           
=======================================
  Hits         8740     8740           
  Misses        810      810
Impacted Files Coverage Δ
reframe/core/exceptions.py 82.03% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 166cf73...a942ac8. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented May 19, 2019 •
edited
Loading

Codecov Report

Merging #790 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #790   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files          76       76           
  Lines        9550     9550           
=======================================
  Hits         8740     8740           
  Misses        810      810
Impacted Files Coverage Δ
reframe/core/exceptions.py 82.03% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 166cf73...a942ac8. Read the comment docs.

@vkarak vkarak merged commit 315b7ec into reframe-hpc:master May 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@teojgo teojgo teojgo approved these changes

Assignees

@aurianer aurianer

Labels

bugfix prio: normal

Projects

None yet

Milestone

ReFrame sprint 2019w20

Development

Successfully merging this pull request may close these issues.

Mixed out/err error message

5 participants

@aurianer @jenkins-cscs @teojgo @vkarak @codecov-io