[bugfix] Add version checks for TMod and TMod4 #794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Throw `ConfigError` for TMod4 versions less than 4.1.0. * Change the corresponding docs.
Contributor
Author
|
@jenkins-cscs retry all |
vkarak
requested changes
May 21, 2019
Contributor
|
@teojgo Can you also do the same for standard Tmod. There the minimum version is |
vkarak
changed the title
vkarak
requested changes
May 22, 2019
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
lgtm, except for a small correction.
vkarak
changed the title
vkarak
reviewed
May 22, 2019
vkarak
approved these changes
May 22, 2019
Contributor
|
@jenkins-cscs retry none |
Codecov Report
@@ Coverage Diff @@
## master #794 +/- ##
==========================================
- Coverage 91.64% 91.51% -0.13%
==========================================
Files 78 78
Lines 9775 9791 +16
==========================================
+ Hits 8958 8960 +2
- Misses 817 831 +14
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConfigErrorfor TMod4 versions older than 4.1.0.ConfigErrorfor TMod versions older than 3.2.Fixes #780
Fixes #781