[feat] Validate test case graph #797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
There seems to be a problem with Python 3.5 in this PR. |
Contributor
@vkarak the cycles found are correct but are not the expected ones. It might have to do with the fact that Python3.5 does not respect the insertion order of the dictionary keys. Maybe alter the test cases so that only one cycle is possible or test for either one. |
teojgo
requested changes
May 24, 2019
- We are now implemeting DFS for all possible sources that has not yet been visited in a previous search. - A couple of unit tests were also added.
teojgo
approved these changes
May 27, 2019
Contributor
Author
|
@jenkins-cscs retry none |
Codecov Report
@@ Coverage Diff @@
## master #797 +/- ##
==========================================
+ Coverage 91.51% 91.59% +0.07%
==========================================
Files 78 78
Lines 9791 9884 +93
==========================================
+ Hits 8960 9053 +93
Misses 831 831
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the validation routine for the test graph. Dependencies are validated at the test level only, so pseudo-dependencies like the following are not allowed:
Fixes UES-283.