[test] Make OSU tests check generic #801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarak
changed the title
vkarak
changed the title
Contributor
|
Minor comments: add comment L18 |
jgphpc
reviewed
May 24, 2019
Contributor
|
|
Contributor
|
P2PBaseTest derived tests will not be on the list of checks to run by default, is it because they are |
jgphpc
approved these changes
May 24, 2019
vkarak
requested changes
May 24, 2019
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
Please add also the benchmark tag.
Contributor
|
@jgphpc We should not take care of the Monch test at all. |
vkarak
approved these changes
May 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses UES-339