Skip to content

[test] Add dom:mc as valid system to IntelRooflineAdvisorTest #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 5, 2019
Merged

[test] Add dom:mc as valid system to IntelRooflineAdvisorTest #814

merged 3 commits into from
Jun 5, 2019

Conversation

@jgphpc
Copy link
Contributor

@jgphpc jgphpc commented May 31, 2019

Will fix UES-418

@jgphpc jgphpc requested a review from teojgo May 31, 2019 11:37
@jgphpc jgphpc self-assigned this May 31, 2019
@jgphpc jgphpc requested a review from kraushm May 31, 2019 11:37
@jgphpc
Copy link
Contributor Author

jgphpc commented May 31, 2019

@jenkins-cscs retry all

@teojgo teojgo changed the title [bugfix ]new slurm fixes memory issue [bugfix] new slurm fixes memory issue May 31, 2019
kraushm
kraushm approved these changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@kraushm kraushm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jgphpc
Copy link
Contributor Author

jgphpc commented Jun 3, 2019

It passed:

[       OK ] IntelRooflineAdvisorTest_100000_597843_G3_AOS_VECTOR on dom:mc using PrgEnv-intel
[       OK ] IntelRooflineAdvisorTest_100000_597843_G3_AOS_SCALAR on dom:mc using PrgEnv-intel
[       OK ] IntelRooflineAdvisorTest_100000_597843_G3_SOA_SCALAR on dom:mc using PrgEnv-intel
[       OK ] IntelRooflineAdvisorTest_100000_597843_G3_SOA_VECTOR on dom:mc using PrgEnv-intel

@teojgo
Copy link
Contributor

teojgo commented Jun 3, 2019

@jenkins-cscs retry all

victorusu
victorusu approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@victorusu victorusu mentioned this pull request Jun 5, 2019
Merged
@vkarak
Copy link
Contributor

vkarak commented Jun 5, 2019

@jenkins-cscs retry dom

@vkarak vkarak changed the title [bugfix] new slurm fixes memory issue [test] new slurm fixes memory issue Jun 5, 2019
@vkarak vkarak changed the title [test] new slurm fixes memory issue [test] Add dom:mc as valid system to IntelRooflineAdvisorTest Jun 5, 2019
@vkarak vkarak merged commit 53fa03f into reframe-hpc:master Jun 5, 2019
@jgphpc jgphpc deleted the UES-418 branch June 6, 2019 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@victorusu victorusu victorusu approved these changes

@teojgo teojgo teojgo approved these changes

+1 more reviewer

@kraushm kraushm kraushm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jgphpc jgphpc

Labels

prio: normal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jgphpc @teojgo @vkarak @victorusu @kraushm