[feat] Implement topological sort of the test cases #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This is a necessary step for running interdependent tests with the serial execution policy. - This commit adds also an implementation of an ordered set. This data structure is quite useful in several contexts and is indeed used extensively in implementing the test dependencies. Its implementation is based on an `OrderedDict`, but it provides the complete `Set` and `MutableSet` interfaces.
|
Hello @vkarak, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2019-06-12 18:10:36 UTC |
Contributor
Author
|
I have identified the problem with the unit tests on Python 3.5 and I will fix them. |
added 3 commits
June 6, 2019 00:28
- The algorithm wasn't checking that the next node picked for visiting was already visited. Thus, it was not producing a valid ordering. - Updated unit tests to check any possible ordering of the cases.
Codecov Report
@@ Coverage Diff @@
## master #815 +/- ##
==========================================
+ Coverage 91.83% 91.87% +0.03%
==========================================
Files 80 80
Lines 9982 10277 +295
==========================================
+ Hits 9167 9442 +275
- Misses 815 835 +20
Continue to review full report at Codecov.
|
added 2 commits
June 6, 2019 21:52
teojgo
requested changes
Jun 11, 2019
teojgo
approved these changes
Jun 12, 2019
Contributor
Author
|
@jenkins-cscs retry none |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serial execution policy.
This data structure is quite useful in several contexts and is indeed
used extensively in implementing the test dependencies. Its
implementation is based on an
OrderedDict, but it provides thecomplete
SetandMutableSetinterfaces.Fixes UES-284.