-
Notifications
You must be signed in to change notification settings - Fork 117
[test] Make MCH halo cell exchange generic #826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @ajocksch, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2019-06-12 14:26:30 UTC |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still not generic due to the else here: https://github.com/eth-cscs/reframe/blob/4e8fc4f7fe4657b81dc0182b014ff29cbd3ae7f4/cscs-checks/mch/collectives_halo.py#L33
This should be an else if for the systems that have the modules you specify. You will also need a separate else setting only the num_tasks etc.
|
I hope it is generic enough; the new else branch is a bit guesswork |
|
@jenkins-cscs retry none |
Codecov Report
@@ Coverage Diff @@
## master #826 +/- ##
=======================================
Coverage 91.81% 91.81%
=======================================
Files 80 80
Lines 9982 9982
=======================================
Hits 9165 9165
Misses 817 817Continue to review full report at Codecov.
|
No description provided.