Skip to content

Conversation

@ajocksch
Copy link
Contributor

@ajocksch ajocksch commented Jun 7, 2019

No description provided.

@pep8speaks
Copy link

pep8speaks commented Jun 7, 2019

Hello @ajocksch, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2019-06-12 14:26:30 UTC

@ajocksch ajocksch changed the title MCH halo cell exchange generic [test] MCH halo cell exchange generic Jun 7, 2019
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still not generic due to the else here: https://github.com/eth-cscs/reframe/blob/4e8fc4f7fe4657b81dc0182b014ff29cbd3ae7f4/cscs-checks/mch/collectives_halo.py#L33

This should be an else if for the systems that have the modules you specify. You will also need a separate else setting only the num_tasks etc.

@ajocksch
Copy link
Contributor Author

I hope it is generic enough; the new else branch is a bit guesswork

@vkarak
Copy link
Contributor

vkarak commented Jun 12, 2019

@jenkins-cscs retry none

@codecov-io
Copy link

codecov-io commented Jun 12, 2019

Codecov Report

Merging #826 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #826   +/-   ##
=======================================
  Coverage   91.81%   91.81%           
=======================================
  Files          80       80           
  Lines        9982     9982           
=======================================
  Hits         9165     9165           
  Misses        817      817

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f05307...be081fe. Read the comment docs.

@vkarak vkarak changed the title [test] MCH halo cell exchange generic [test] Make MCH halo cell exchange generic Jun 12, 2019
@vkarak vkarak merged commit 2327265 into reframe-hpc:master Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants