[test] Set num_cpus_per_task to the TensorFlow Horovod test
#831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgphpc
approved these changes
Jun 13, 2019
Contributor
|
@jenkins-cscs retry kesch |
vkarak
approved these changes
Jun 13, 2019
vkarak
changed the title
Contributor
|
@jenkins-cscs retry none |
Codecov Report
@@ Coverage Diff @@
## master #831 +/- ##
=======================================
Coverage 91.87% 91.87%
=======================================
Files 80 80
Lines 10277 10277
=======================================
Hits 9442 9442
Misses 835 835Continue to review full report at Codecov.
|
vkarak
changed the title
num_cpus_per_task to the TensorFlow Horovod test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jgphpc found that in this test, doing
export OMP_NUM_THREADS=$SLURM_CPUS_PER_TASKproduce the messagelibgomp: Invalid value for environment variable OMP_NUM_THREADSbecause as--cpus-per-taskis not defined,SLURM_CPUS_PER_TASKhas no value. This PR addsself.num_cpus_per_task = 12to the test.