Skip to content

[test] Update IOR check #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 3, 2019
Merged

[test] Update IOR check #838

merged 12 commits into from
Jul 3, 2019

Conversation

@GiuseppeLoRe
Copy link
Contributor

@GiuseppeLoRe GiuseppeLoRe commented Jun 17, 2019

Resumed work on reframe-ior tests.

Update of ior_check
3d6391c 
Resumed work on reframe-ior tests.
@pep8speaks
Copy link

pep8speaks commented Jun 17, 2019 •
edited
Loading

Hello @GiuseppeLoRe, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2019-07-03 10:05:31 UTC

@jenkins-cscs
Copy link
Collaborator

jenkins-cscs commented Jun 17, 2019

Can I test this patch?

@victorusu
Copy link
Contributor

victorusu commented Jun 17, 2019

test this please

@vkarak vkarak requested review from victorusu and vkarak June 17, 2019 12:29
@vkarak
Copy link
Contributor

vkarak commented Jun 17, 2019

@victorusu "test this please" is not the magic word.

@jenkins-cscs retry all

@teojgo
Copy link
Contributor

teojgo commented Jun 17, 2019 •
edited
Loading

@jenkins-cscs retry all

Update on ior_check
4a34b22 
Started to apply coding convention rules.
@codecov-io
Copy link

codecov-io commented Jun 17, 2019 •
edited
Loading

Codecov Report

Merging #838 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #838   +/-   ##
=======================================
  Coverage   91.84%   91.84%           
=======================================
  Files          80       80           
  Lines       10215    10215           
=======================================
  Hits         9382     9382           
  Misses        833      833

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d931e0...a3179fa. Read the comment docs.

@GiuseppeLoRe
Update on ior_check
121e992 
Fixed a few coding violations.
@teojgo
Copy link
Contributor

teojgo commented Jun 24, 2019

@jenkins-cscs retry all

vkarak
vkarak requested changes Jun 25, 2019
View reviewed changes
@vkarak vkarak changed the title [test] Update of ior_check [test] Update IOR check Jun 25, 2019
@vkarak vkarak requested a review from omlins June 25, 2019 18:21
GiuseppeLoRe and others added 4 commits June 25, 2019 14:21
@GiuseppeLoRe
Update on ior_check
b2da2a3 
few comment/style fixes
@GiuseppeLoRe
moved test_dir creation inside self.pre_run
61d55a6
@GiuseppeLoRe @vkarak
Update cscs-checks/system/io/ior_check.py
094bdeb 
Co-Authored-By: Vasileios Karakasis <vkarak@gmail.com>
@GiuseppeLoRe
Update on ior_check
59c0161 
Removed Fulen specifics as they should be fixed in the fulen settings.
vkarak
vkarak requested changes Jun 26, 2019
View reviewed changes
Giuseppe Lo Re and others added 2 commits June 26, 2019 20:46
@vkarak vkarak added this to the ReFrame sprint 2019w23 milestone Jul 1, 2019
vkarak
vkarak requested changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall. I have just a couple of minor comments still.

Can you also cleanup the /apps/common/UES/reframe/resources/IOR from all the unnecessary stuff. Since this is copied over for every test, it is essential to keep there what is strictly needed by the test. I think that the IOR-July12.tar should not be there.

vkarak
vkarak requested changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be more readable to instruct IOR to report numbers in MiB/s rather than B/s. If I now use the --performance-report, I get values in B/s, which are not very human parsable:

IorWriteCheck__scratch_snx1600tds
- dom:gpu
   - PrgEnv-cray
      * write_bw: 3343028060.16 Bytes/s

@vkarak vkarak assigned vkarak and unassigned GiuseppeLoRe Jul 3, 2019
Reset reported b/w values back to MiB/s
94e771b 
Also

- Fixed coding style issues
vkarak
vkarak approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now

@vkarak vkarak merged commit cccfd57 into reframe-hpc:master Jul 3, 2019
@GiuseppeLoRe GiuseppeLoRe deleted the ior branch July 3, 2019 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@victorusu victorusu Awaiting requested review from victorusu

@omlins omlins Awaiting requested review from omlins

Assignees

@vkarak vkarak

Labels

enhancement prio: normal

Projects

None yet

Milestone

ReFrame sprint 2019w23

Development

Successfully merging this pull request may close these issues.

7 participants

@GiuseppeLoRe @pep8speaks @jenkins-cscs @victorusu @vkarak @teojgo @codecov-io