-
Notifications
You must be signed in to change notification settings - Fork 117
[test] Adapt OpenMP flags for CCE 9.0.x in Jacobi tools tests #849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Adapt flags in 'notool' checks. * Adapt flags in 'perftools' checks.
jgphpc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a test for cce-classic but i assume it will be fine this way
|
👍 Thanks for the change. Can you check the new PE (looks like it's ignored) ?
|
|
@jgphpc you have to use the |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please split this PR in two: One for the configuration file and one for adapting the tests.
Codecov Report
@@ Coverage Diff @@
## master #849 +/- ##
=======================================
Coverage 91.69% 91.69%
=======================================
Files 80 80
Lines 10279 10279
=======================================
Hits 9425 9425
Misses 854 854Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #849 +/- ##
==========================================
- Coverage 91.71% 91.69% -0.02%
==========================================
Files 80 80
Lines 10279 10279
==========================================
- Hits 9427 9425 -2
- Misses 852 854 +2
Continue to review full report at Codecov.
|
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Adapt flags in 'notool' checks.
Adapt flags in 'perftools' checks.