Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Jul 1, 2019

  • Adapt flags in 'notool' checks.

  • Adapt flags in 'perftools' checks.

* Adapt flags in 'notool' checks.

* Adapt flags in 'perftools' checks.
@teojgo teojgo added this to the ReFrame sprint 2019w23 milestone Jul 1, 2019
@teojgo teojgo requested review from jgphpc and vkarak July 1, 2019 08:51
@teojgo teojgo self-assigned this Jul 1, 2019
Copy link
Contributor

@jgphpc jgphpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a test for cce-classic but i assume it will be fine this way

@jgphpc
Copy link
Contributor

jgphpc commented Jul 1, 2019

👍

Thanks for the change. Can you check the new PE (looks like it's ignored) ?

reframe --prgenv PrgEnv-cray_classic ...

[----------] started processing JacobiNoToolHybrid_Cpp (Jacobi (without tool) C++ check)
[ RUN      ] JacobiNoToolHybrid_Cpp on dom:mc using PrgEnv-cray
[ RUN      ] JacobiNoToolHybrid_Cpp on dom:mc using PrgEnv-gnu

@teojgo
Copy link
Contributor Author

teojgo commented Jul 1, 2019

@jgphpc you have to use the -C config/cscs.py option

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split this PR in two: One for the configuration file and one for adapting the tests.

@codecov-io
Copy link

codecov-io commented Jul 4, 2019

Codecov Report

Merging #849 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #849   +/-   ##
=======================================
  Coverage   91.69%   91.69%           
=======================================
  Files          80       80           
  Lines       10279    10279           
=======================================
  Hits         9425     9425           
  Misses        854      854

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53b4463...ccaa18b. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #849 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #849      +/-   ##
==========================================
- Coverage   91.71%   91.69%   -0.02%     
==========================================
  Files          80       80              
  Lines       10279    10279              
==========================================
- Hits         9427     9425       -2     
- Misses        852      854       +2
Impacted Files Coverage Δ
reframe/core/config.py 83.78% <0%> (-1.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5657393...4a1fb52. Read the comment docs.

@vkarak vkarak changed the title [test] Adapt OpenMP flags for CCE 9.0.x in jacobi tests [test] Adapt OpenMP flags for CCE 9.0.x in Jacobi tools tests Jul 4, 2019
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit 4fcc116 into reframe-hpc:master Jul 4, 2019
@teojgo teojgo deleted the test/jacobi_cpp branch July 4, 2019 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants