Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Jul 4, 2019

  • This solves the problem of the ci trying to interpret github comments of 3rd party tools like codecov/pep8speaks.

  • The comment is only taken into account if it starts with "@jenkins-cscs".

@teojgo teojgo added this to the ReFrame sprint 2019w23 milestone Jul 4, 2019
@teojgo teojgo requested a review from vkarak July 4, 2019 06:14
@teojgo teojgo self-assigned this Jul 4, 2019
@codecov-io
Copy link

codecov-io commented Jul 4, 2019

Codecov Report

Merging #859 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #859   +/-   ##
=======================================
  Coverage   91.71%   91.71%           
=======================================
  Files          80       80           
  Lines       10279    10279           
=======================================
  Hits         9427     9427           
  Misses        852      852

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5657393...4e336ed. Read the comment docs.

@vkarak vkarak changed the title [ci] Run ci if not triggered by a comment [ci] Run CI if not triggered by a comment Jul 4, 2019
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put a description in your PR description explaining better what is the problem that it is solving?

@vkarak vkarak changed the title [ci] Run CI if not triggered by a comment [ci] Ignore irrelevant @ comments when triggering the CI Jul 4, 2019
@vkarak vkarak merged commit fd9abff into reframe-hpc:master Jul 4, 2019
@teojgo teojgo deleted the ci/triggered_no_comment branch July 4, 2019 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants