Skip to content

[feat] Add automatically a default * reference for performance checks #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jul 23, 2019
Merged

[feat] Add automatically a default * reference for performance checks #866

merged 19 commits into from
Jul 23, 2019

Conversation

@ChristopherBignamini
Copy link
Contributor

@ChristopherBignamini ChristopherBignamini commented Jul 9, 2019 •
edited by teojgo
Loading

Fixes #811

@pep8speaks
Copy link

pep8speaks commented Jul 9, 2019 •
edited
Loading

Hello @ChristopherBignamini, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2019-07-23 13:22:11 UTC

@teojgo teojgo added this to the ReFrame sprint 2019w23 milestone Jul 9, 2019
@vkarak
Copy link
Contributor

vkarak commented Jul 9, 2019

@ChristopherBignamini Why this is a WIP?

@vkarak vkarak requested review from teojgo and vkarak July 10, 2019 09:13
@vkarak
Copy link
Contributor

vkarak commented Jul 10, 2019

@ChristopherBignamini Please take a look at the unit tests failures.

teojgo
teojgo requested changes Jul 10, 2019
View reviewed changes
@codecov-io
Copy link

codecov-io commented Jul 10, 2019 •
edited
Loading

Codecov Report

Merging #866 into master will increase coverage by 0.04%.
The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #866      +/-   ##
==========================================
+ Coverage   91.69%   91.73%   +0.04%     
==========================================
  Files          78       78              
  Lines       10282    10309      +27     
==========================================
+ Hits         9428     9457      +29     
+ Misses        854      852       -2
Impacted Files Coverage Δ
unittests/test_pipeline.py 97.46% <100%> (+0.02%) ⬆️
reframe/core/pipeline.py 93.63% <95.65%> (+0.11%) ⬆️
reframe/utility/__init__.py 89.66% <0%> (+0.33%) ⬆️
reframe/core/config.py 85.58% <0%> (+1.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e50ae99...bced3d5. Read the comment docs.

@ChristopherBignamini ChristopherBignamini changed the title [wip] [feat] Default '*' reference for performance check run time addition [feat] Default '*' reference for performance check run time addition Jul 10, 2019
teojgo
teojgo requested changes Jul 10, 2019
View reviewed changes
@vkarak vkarak removed this from the ReFrame sprint 2019w23 milestone Jul 13, 2019
@victorusu victorusu added this to the ReFrame sprint 2019w29 milestone Jul 16, 2019
vkarak
vkarak requested changes Jul 17, 2019
View reviewed changes
@vkarak vkarak changed the title [feat] Default '*' reference for performance check run time addition [feat] Add automatically a default * reference for performance checks Jul 23, 2019
vkarak
vkarak requested changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a small bug for cases when the reference is not defined at all. I am fixing it now.

@vkarak vkarak merged commit 096c286 into reframe-hpc:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@teojgo teojgo teojgo approved these changes

Assignees

@ChristopherBignamini ChristopherBignamini

Labels

enhancement prio: normal

Projects

None yet

Milestone

ReFrame sprint 2019w29

Development

Successfully merging this pull request may close these issues.

Add always a default * reference if it does not exist

6 participants

@ChristopherBignamini @pep8speaks @vkarak @codecov-io @teojgo @victorusu