[test] Workaround for netcdf test with PrgEnv-pgi #870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teojgo
changed the title
omlins
suggested changes
Jul 12, 2019
Contributor
omlins
left a comment
omlins
left a comment
There was a problem hiding this comment.
I don't think that we need to find a workaround to make it build. The test should check that it builds as it is and if it doesn't then it should continue to fail. This is a bug and CRAY confirmed it (I opened a CRAY case a couple of days ago: Case #243751). Cray is working on it.
Contributor
|
@omlins I don't see a problem merging the version with the workaround so far that this is clearly stated in the test. We don't know when Cray will be fixing this and we want somehow to "document" this workaround inside the test. We can stall this PR, h however, until we get a fix, but if it takes too long, we will merge it. |
vkarak
requested changes
Jul 15, 2019
omlins
approved these changes
Jul 23, 2019
vkarak
approved these changes
Jul 23, 2019
Contributor
|
I am merging despite the failure on Kesch, because it fails also on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.