[test] Enable performance reporting in the flexible alltoall OSU benchmark #908
Conversation
|
Hello @ajocksch, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2019-09-14 12:21:43 UTC |
ajocksch
changed the title
ajocksch
changed the title
|
Shall I merge the "alltoall" check with the "Flexible alltoall" check? |
|
@ajocksch For a PR to be merged, at least one approving review is needed. I'll have a look at it today. |
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
You should not merge the tests, because we cannot have a safe reference depending on the number of nodes. What you can do instead is add perf_patterns to the flexible version, so that we can use it with the --performance-report option. You don't even to set a reference, cos ReFrame will automatically insert a generic one. I think this from 2.18 onward, so you should use the @required_version decorator as well.
vkarak
changed the title
|
@ajocksch Can you please address my comments here, so that we can merge it? |
vkarak
changed the title
…frame into benchmarks/flexible_alltoall
|
Regarding the CI: opened JIRA issue for the failing tests on Kesch and the failure on Dom is due to lack of resources. Merging. |
3 participants
No description provided.