Skip to content

[test] Increase iterations for async kernel latency test #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 30, 2019
Merged

[test] Increase iterations for async kernel latency test #910

merged 5 commits into from
Aug 30, 2019

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Aug 27, 2019

  • Add PrgEnv-cray_classic in programming environments

Revise limits for async kernel latency test
9218ae2 
* Add PrgEnv-cray_classic in programming environments
@teojgo teojgo requested a review from vkarak August 27, 2019 11:37
@teojgo teojgo self-assigned this Aug 27, 2019
@codecov-io
Copy link

codecov-io commented Aug 27, 2019 •
edited
Loading

Codecov Report

Merging #910 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #910   +/-   ##
======================================
  Coverage    91.7%   91.7%           
======================================
  Files          78      78           
  Lines       10340   10340           
======================================
  Hits         9482    9482           
  Misses        858     858

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab6e969...947f028. Read the comment docs.

vkarak
vkarak requested changes Aug 28, 2019
View reviewed changes
@teojgo teojgo changed the title [test] Revise limits for async kernel latency test [test] Increase iterations for async kernel latency test Aug 28, 2019
vkarak
vkarak approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@teojgo
Copy link
Contributor Author

teojgo commented Aug 28, 2019

@vkarak can you merge #912 first to see if it runs correctly the benchmark test?

@vkarak
Copy link
Contributor

vkarak commented Aug 28, 2019

@teojgo I've check it manually. Everything's green.

@vkarak vkarak merged commit 734abec into reframe-hpc:master Aug 30, 2019
@teojgo teojgo deleted the test/kernel_latency branch October 24, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

Assignees

@teojgo teojgo

Labels

prio: normal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@teojgo @codecov-io @vkarak