Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Aug 28, 2019

Fixes #882

@teojgo teojgo added this to the ReFrame sprint 2019w35 milestone Aug 28, 2019
@teojgo teojgo requested a review from vkarak August 28, 2019 07:33
@teojgo teojgo self-assigned this Aug 28, 2019
@codecov-io
Copy link

Codecov Report

Merging #911 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #911   +/-   ##
======================================
  Coverage    91.7%   91.7%           
======================================
  Files          78      78           
  Lines       10340   10340           
======================================
  Hits         9482    9482           
  Misses        858     858
Impacted Files Coverage Δ
reframe/core/pipeline.py 93.63% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab6e969...c14f53f. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak
Copy link
Contributor

vkarak commented Aug 28, 2019

@lucamar Can you check if this PR fixes the problem you had in #882?

@vkarak vkarak changed the title [feat] Use login shell when building executables [bugfix] Use login shell when building executables Aug 28, 2019
@vkarak vkarak added bugfix and removed enhancement labels Aug 28, 2019
@vkarak
Copy link
Contributor

vkarak commented Aug 29, 2019

@jenkins-cscs retry none

@vkarak vkarak merged commit 129562f into reframe-hpc:master Aug 29, 2019
@teojgo teojgo deleted the feature/bash_login_build branch October 24, 2019 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to use login shell to build executables

3 participants