[feat] Add support for TMod version 3.1

[victorusu]

Extend the TMod implementation to add support for modules 3.1.

Fixes #784.

[pep8speaks]

Hello @victorusu, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2019-11-25 21:41:24 UTC

[vkarak]

It seems that Tmod 3.1 has a completely different output and its basic command is also diverse. I think it would make sense to define a separate modules implementation, named tmod31. For symmetry, we can define tmod32 and make tmod and alias to that.

[vkarak]

I think that everything in all four implementations (TMod, TMod31, TMod4 and LMod) boils down to three basic differences (correct me if I'm wrong):

1. modulecmd command (python bindings are got in the same way as soon as you have the modulecmd)
2. Command to get the version string (version strings are all in . format at least)
3. How python bindings are executed.

Thus if you abstract only these three things in the base class, which imho, could simply be the standard TModImpl, then the subclasses would have just to override these three functions only. Currently, there is lots of unnecessary code duplication between all the three modules systems.

[codecov-io]

Codecov Report

Merging #935 into master will decrease coverage by 0.3%.
The diff coverage is 15.21%.

@@            Coverage Diff            @@
##           master    #935      +/-   ##
=========================================
- Coverage      92%   91.7%   -0.31%     
=========================================
  Files          81      81              
  Lines       11030   11076      +46     
=========================================
+ Hits        10148   10157       +9     
- Misses        882     919      +37

Impacted Files	Coverage Δ
reframe/core/modules.py	60.66% <15.21%> (-6.1%)	⬇️
reframe/core/config.py	84.61% <0%> (+1.7%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7fa1be...f9ab9ab. Read the comment docs.

[vkarak]

I will merge this as soon as you update the documentation. It's not exactly what I want, because the code duplication is not addressed, but I will merge it since it has been standing for long time. I will open a follow up issue on refactoring the modules backend implementation. See #1063.