Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Sep 24, 2019

This PR adds the option --non-default-craype that enables ReFrame to test non-default Cray programming environments. This option causes ReFrame to export properly the LD_LIBRARY_PATH after loading any additional user modules. Use as follows:

module load cdt/19.09   # load target PE
reframe ... --non-default-craype -r

Fixes #895.

@codecov-io
Copy link

codecov-io commented Sep 24, 2019

Codecov Report

Merging #949 into master will decrease coverage by 0.01%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #949      +/-   ##
==========================================
- Coverage   91.64%   91.63%   -0.02%     
==========================================
  Files          79       79              
  Lines       10482    10492      +10     
==========================================
+ Hits         9606     9614       +8     
- Misses        876      878       +2
Impacted Files Coverage Δ
reframe/core/runtime.py 88.35% <100%> (+0.24%) ⬆️
reframe/frontend/cli.py 80.32% <66.66%> (+0.06%) ⬆️
reframe/core/pipeline.py 93.77% <91.66%> (-0.14%) ⬇️
reframe/frontend/dependency.py 95.91% <0%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56fba8a...c9a34d6. Read the comment docs.

@vkarak vkarak changed the title [feat] Enable easy testing non-default Cray programming environments [feat] Enable easy testing of non-default Cray programming environments Sep 24, 2019
@vkarak vkarak force-pushed the feat/non-default-craype branch from 5931d82 to 9305fff Compare September 25, 2019 21:38
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I just have a question regarding the API growth. I wonder if we want to make use of kwargs.
What was not so clear to me also, is the use case.
If the system is a non-default cray but contains a Cray PE, then this should be reported in the definition of the programming environment, no? Or we just want a flag to trigger it?

@vkarak vkarak merged commit bfbc348 into reframe-hpc:master Sep 27, 2019
@vkarak vkarak deleted the feat/non-default-craype branch September 27, 2019 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adapt ReFrame to test non-default Cray Programming Environments

3 participants