Skip to content

Conversation

@victorusu
Copy link
Contributor

Additionally, I have removed the obsolete Monch tests.

Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the super().__init__() from the base class.

@codecov-io
Copy link

codecov-io commented Sep 27, 2019

Codecov Report

Merging #950 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #950      +/-   ##
==========================================
- Coverage   91.64%   91.64%   -0.01%     
==========================================
  Files          79       79              
  Lines       10482    10492      +10     
==========================================
+ Hits         9606     9615       +9     
- Misses        876      877       +1
Impacted Files Coverage Δ
reframe/core/pipeline.py 93.77% <0%> (-0.14%) ⬇️
reframe/frontend/cli.py 80.32% <0%> (+0.06%) ⬆️
reframe/core/runtime.py 88.35% <0%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56fba8a...3c90b5c. Read the comment docs.

@vkarak
Copy link
Contributor

vkarak commented Sep 27, 2019

Remove the super().__init__() from the base class.

@victorusu If you do that, make sure to decorate your test with @required_version(...), because this is quite recent change.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak changed the title [test] Update gromacs ref value [test] Update Gromacs reference value Sep 27, 2019
- And update ReFrame's required version
@vkarak vkarak requested a review from teojgo September 27, 2019 13:25
@vkarak vkarak merged commit dd393b6 into reframe-hpc:master Sep 28, 2019
@victorusu victorusu deleted the test/update-gromacs-ref branch October 6, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants