Skip to content

Conversation

@jfavre
Copy link
Contributor

@jfavre jfavre commented Oct 9, 2019

Address issue related to ParaView hanging after job completion

https://jira.cscs.ch/browse/MAINT-66

@pep8speaks
Copy link

pep8speaks commented Oct 9, 2019

Hello @jfavre, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2019-10-11 12:29:28 UTC

@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #962 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #962      +/-   ##
==========================================
+ Coverage   91.67%   91.86%   +0.18%     
==========================================
  Files          80       80              
  Lines       10575    10481      -94     
==========================================
- Hits         9695     9628      -67     
+ Misses        880      853      -27
Impacted Files Coverage Δ
reframe/core/schedulers/__init__.py 95.58% <0%> (-0.22%) ⬇️
reframe/core/pipeline.py 93.47% <0%> (-0.14%) ⬇️
unittests/test_pipeline.py 96.71% <0%> (-0.01%) ⬇️
reframe/utility/__init__.py 90% <0%> (ø) ⬆️
unittests/test_schedulers.py 96.85% <0%> (ø) ⬆️
unittests/test_utility.py 99.21% <0%> (ø) ⬆️
reframe/frontend/cli.py 80.38% <0%> (+0.06%) ⬆️
unittests/test_environments.py 73.15% <0%> (+2.16%) ⬆️
reframe/core/environments.py 92.37% <0%> (+5.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9832a6b...bb03675. Read the comment docs.

Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix the final pep8 issue and then it's ready.

@codecov-io
Copy link

codecov-io commented Oct 11, 2019

Codecov Report

Merging #962 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #962      +/-   ##
==========================================
- Coverage   91.86%   91.85%   -0.01%     
==========================================
  Files          80       80              
  Lines       10481    10481              
==========================================
- Hits         9628     9627       -1     
- Misses        853      854       +1
Impacted Files Coverage Δ
reframe/frontend/dependency.py 95.91% <0%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 169ab2d...ddcdb2e. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfavre I will move the new colored sphere to the old one. There is no need to keep both. Git is doing that for us. I will also fix the final PEP8 issue.

@teojgo The coding style is only for ReFrame and our tests. So @jfavre, sorry if we bothered you too much for fixing the colored sphere.

@vkarak vkarak merged commit 2c4cffd into reframe-hpc:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants