Skip to content

[test] Port collectives halo exchange check to Tiger #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 16, 2019
Merged

[test] Port collectives halo exchange check to Tiger #970

merged 3 commits into from
Oct 16, 2019

Conversation

@jgphpc
Copy link
Contributor

@jgphpc jgphpc commented Oct 11, 2019

Will fix UES-567

@jgphpc jgphpc requested review from ajocksch and vkarak October 11, 2019 12:49
@jgphpc jgphpc self-assigned this Oct 11, 2019
@vkarak vkarak added this to the ReFrame Sprint 2019w41 milestone Oct 11, 2019
@jgphpc
Copy link
Contributor Author

jgphpc commented Oct 15, 2019

@jenkins-cscs retry all

[     FAIL ] HaloExchangeTest_nocomp on kesch:cn using PrgEnv-gnu
[     FAIL ] HaloExchangeTest_default on kesch:cn using PrgEnv-gnu

vkarak
vkarak approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jgphpc jgphpc changed the title [test] port collectives_halo checks to tiger [test] Port COLLECTIVES_HALO check to Tiger Oct 16, 2019
@vkarak vkarak changed the title [test] Port COLLECTIVES_HALO check to Tiger [test] Port collectives halo exchange check to Tiger Oct 16, 2019
@vkarak
Copy link
Contributor

vkarak commented Oct 16, 2019 •
edited
Loading

@jenkins-cscs retry none

@codecov-io
Copy link

codecov-io commented Oct 16, 2019 •
edited
Loading

Codecov Report

Merging #970 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #970   +/-   ##
=======================================
  Coverage   91.82%   91.82%           
=======================================
  Files          80       80           
  Lines       10674    10674           
=======================================
  Hits         9801     9801           
  Misses        873      873

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 762b05e...3de1347. Read the comment docs.

@vkarak vkarak merged commit ea9172c into reframe-hpc:master Oct 16, 2019
@jgphpc jgphpc deleted the UES-567_halo branch October 23, 2019 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@ajocksch ajocksch Awaiting requested review from ajocksch

Assignees

@jgphpc jgphpc

Labels

prio: normal

Projects

None yet

Milestone

ReFrame Sprint 2019w41

Development

Successfully merging this pull request may close these issues.

3 participants

@jgphpc @vkarak @codecov-io