Skip to content

Fix: Handle special characters in the inputs#20

Merged
sudo-bmitch merged 1 commit into
regclient:mainfrom
sudo-bmitch:pr-handle-special-chars
Oct 16, 2024
Merged

Fix: Handle special characters in the inputs#20
sudo-bmitch merged 1 commit into
regclient:mainfrom
sudo-bmitch:pr-handle-special-chars

Conversation

@sudo-bmitch
Copy link
Copy Markdown
Contributor

Fixes issue

Fixes #18

Describe the change

Handle special characters in the inputs by passing them as environment variables. This also validates the change with tests and ensures the password is always masked in output.

How to verify it

GHA tests are included in test-action.yml.

Changelog text

  • Fix: Handle special characters in the inputs.
  • Feat: Support passing additional options to regctl registry login like --skip-check.

Please verify and check that the pull request fulfills the following requirements

  • Tests have been added or not applicable
  • Documentation has been added, updated, or not applicable
  • Changes have been rebased to main
  • Multiple commits to the same code have been squashed

Signed-off-by: Brandon Mitchell <git@bmitch.net>
@sudo-bmitch sudo-bmitch force-pushed the pr-handle-special-chars branch from 0068199 to 9db7ecb Compare October 16, 2024 14:50
@sudo-bmitch sudo-bmitch merged commit ce5fd13 into regclient:main Oct 16, 2024
@sudo-bmitch sudo-bmitch deleted the pr-handle-special-chars branch October 16, 2024 14:52
@sudo-bmitch sudo-bmitch mentioned this pull request Oct 16, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

may cause auth error if password include letter $

1 participant