Fix: Fixing installer for separate commands#34
Merged
Conversation
sudo-bmitch
force-pushed
the
pr-fix-cmd-installer
branch
3 times, most recently
from
7798ace to
1079a74
Compare
Other methods to reuse the workflow won't easily work. The path to a shell script is limited to the current folder. Checking out the action externally requires a reference that I won't have. Signed-off-by: Brandon Mitchell <git@bmitch.net>
sudo-bmitch
force-pushed
the
pr-fix-cmd-installer
branch
from
1079a74 to
9c47eb5
Compare
sudo-bmitch
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue
regctl-installer is broken for external users.
Describe the change
Unfortunately, the best solution I've found is to duplicate the script across multiple files. This is pretty ugly, but the only other option that might work is to checkout the actions repo and that would go into the workspace of everyone using this action, and would make this no longer self contained.
Trying to call an external shell script doesn't work because all paths are scoped to the directory of the action, and each action has a separate directory. And trying to call the workflow externally requires a github ref that I don't think I can get from GitHub actions, and even if I could would mean that working in forks of this would all point back to this repo (perhaps more variables could be used, but the error messages weren't promising).
How to verify it
Changelog text
Please verify and check that the pull request fulfills the following requirements