Conversation
…we tab out and back
…key, rather than the *effective* end cell We were getting stuck in loops where the actual end cell was a cell that, due to merging, was expanding the selection further - and then trying to shift+arrow in the opposite direction to that extension put the end cell back in the original "actual" end cell, which then expanded out to put the selection exactly back where it was.
...but tabbing out destroys the selection, which means our use case of setting up a selection then tabbing to a submit button doesn't work.
rossjones
reviewed
Dec 12, 2024
Contributor
rossjones
left a comment
rossjones
left a comment
There was a problem hiding this comment.
LGTM. Tried it out and worked as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #61
This grew into a wider accessibility audit.