merge changes from OwainJones-patch-1 into new branch recreated from main#317
Merged
OwainJones merged 18 commits intouser-defined-tablesfrom Sep 17, 2025
Merged
merge changes from OwainJones-patch-1 into new branch recreated from main#317OwainJones merged 18 commits intouser-defined-tablesfrom
OwainJones merged 18 commits intouser-defined-tablesfrom
Conversation
Updating for tables
… to get defined tables Excel.js only offered an async API to load files, so we couldn't use it :'-( # Conflicts: # lib/importer/package.json # lib/importer/src/dudk/backend.js
…tion.js and sheet.js for selecting user defined tables.
…ets.js to select and preview tables.
…elector and to extract the header row automatically
OwainJones
added a commit
that referenced
this pull request
Oct 29, 2025
* merge changes from OwainJones-patch-1 into new branch recreated from main (#317) * Update backend.js Updating for tables * Added for table testing * Some minor updates to testing * Some updates to tables_test and added a metadata file * Installed our locally "vendored" patched copy of sheet.js and used it to get defined tables Excel.js only offered an async API to load files, so we couldn't use it :'-( # Conflicts: # lib/importer/package.json # lib/importer/src/dudk/backend.js * Licence compliance requirements for SheetJS fork * Added html and nkj files, as well as the associated functions in function.js and sheet.js for selecting user defined tables. * Added njk and html files as well as functions in functions.js and sheets.js to select and preview tables. * A range of edits to fix errros that campe up when testing the table selector and to extract the header row automatically * Several tweaks to code to get table previews to work. * Add files via upload * Delete backend.js * Delete sheets.js * Delete functions.js * Add files via upload * Add files via upload * Add files via upload * Add files via upload --------- Co-authored-by: Alaric Snell-Pym <alaric@register-dynamics.co.uk> * Delete table_selector.njk * Updates for tables attempting to pass multiple urls to route to * Minor updates * Edits to ensure that header identification in tables is working correctly, and to ensure we preserve the new header range. * Added a get and set table function, updated index.js, and various other functions to accomodate tables into the header and footer pages * Added some tweaks to review page to accomodate tables, moved the check for footer rows in SessionPerformMappingJob from if(row) to its parent for loop, as we were having an issue where an empty row in the table footer (i.e. the row immediately below the table) was giving an error. * Tidied up code removing several console.debug lines that were used for debugging * Some updates to how we handle table header and use it in the final mapData step so that we can import data without visible headers * Quick comit to ensure any minor local changes are accounted for * Changes to fix table preview for no table and to fix merge issues --------- Co-authored-by: Alaric Snell-Pym <alaric@register-dynamics.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.