build-and-push: optional Docker Hub login for dual-registry pushes#1
Merged
Conversation
Adds a dockerhub-token secret + dockerhub-user input. When the token is set, the build also logs in to Docker Hub so extra-tags referencing Docker Hub bare repos (e.g. rehosting/penguin:latest) are pushed in the same build. Covers the common publish-to-both-Harbor-and-Docker-Hub pattern (penguin/publish, fw2tar). Harbor- only repos are unaffected (token unset => no Docker Hub login).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
dockerhub-tokensecret +dockerhub-userinput tobuild-and-push.yml. When the token is set, the build also logs in to Docker Hub soextra-tagsreferencing Docker Hub bare repos (e.g.rehosting/penguin:latest) are pushed in the same build.Covers the common publish-to-both-Harbor-and-Docker-Hub pattern (penguin/publish, fw2tar). Backward-compatible: token unset → no Docker Hub login → existing
@v1consumers behave identically.After merge: cut
v1.1.0+ movev1, then penguin/publish's build can migrate ontobuild-and-push.yml@v1with thedockerhub-tokensecret.